Win exit code fix #421
Closed
Win exit code fix #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `shift` command of cmd.exe is not shift `%*`. and use delayed-expansion. immediate expansion cause many troubles of special-characters in arguments.
Conflicts: src/sbt-test/windows/java-app-archetype/build.sbt
The maintainer line is optional in the Dockerfile. While the initial commit assumed that it was required, it appears that this is not the case. We can therefore skip adding the line if the maintainer is not set.
This reverts commit 20d56d6.
Return exit code 1 in windows bat script if java application exits with a return code greater than 0. Update windows bat regression tests to check the returned code.
|
Hi @bjuric, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
|
Accepted CLA. |
|
Thanks for the fix @bjuric . You branched away from You could
You changed an existing test, but only check for object Main extends App {
sys.exit(1)
} |
|
Created new pull request #423 |
|
I'll close this in favor of #423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the setting of the exit code in the windows bat template outside of the localised scope. This ensures that if the call to the java application returns an exit code greater than 0 that the script returns 1 instead of 0.
Also updated regression tests for windows bat testing to check the return code.
The changes were applied to the 0.8.0 branch.
Developed and tested on Windows 7 SP1.